Skip to content

nh3#1509

Merged
jochenklar merged 3 commits into
2.5.0/releasefrom
2.5.0/nh3
Jun 3, 2026
Merged

nh3#1509
jochenklar merged 3 commits into
2.5.0/releasefrom
2.5.0/nh3

Conversation

@jochenklar

Copy link
Copy Markdown
Member

This PR adds the nh3 to clean markdown content. The feature can be controlled by settings.MARKDOWN_CLEAN = True | False and for more fine grained control:

MARKDOWN_CLEAN = True
MARKDOWN_CLEAN_KWARGS = {
    'attributes': {'*': {'style'}},
    'filter_style_properties': {'color'}
}

to allow, e.g., style arguments, but only the color property.

@jochenklar jochenklar requested a review from MyPyDavid January 8, 2026 11:32
@jochenklar jochenklar self-assigned this Jan 8, 2026
@jochenklar jochenklar added this to the RDMO 2.5.0 milestone Jan 8, 2026
@jochenklar jochenklar changed the base branch from main to 2.5.0/release January 8, 2026 11:33
@jochenklar jochenklar changed the title 2.5.0/nh3 nh3 Jan 8, 2026
@MyPyDavid MyPyDavid linked an issue Jan 8, 2026 that may be closed by this pull request
@jochenklar

jochenklar commented Feb 19, 2026

Copy link
Copy Markdown
Member Author

Things that will still work:

<a href="https://rdmorganiser.github.io">rdmo.org</a>

<strong>RDMO</strong>

<details>
  <summary>Epcot Center</summary>
  <p>
    Epcot is a theme park at Walt Disney World Resort featuring exciting attractions,
    international pavilions, award-winning fireworks and seasonal special events.
  </p>
</details>

Things that do not work anymore (without additional settings):

<a href="https://rdmorganiser.github.io" target="_blank">rdmo.org</a>

<span style="color: blue;">RDMO</span>

<span style="margin-right: 1rem;">RDMO</span>

<script>alert(1);</script>

@jochenklar

Copy link
Copy Markdown
Member Author

@MyPyDavid I set MARKDOWN_CLEAN = False so we can merge and release without trouble.

@MyPyDavid MyPyDavid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice way to keep strings clean. ⚗️ 🪣

@jochenklar jochenklar merged commit 5be4b1a into 2.5.0/release Jun 3, 2026
13 of 25 checks passed
@jochenklar jochenklar deleted the 2.5.0/nh3 branch June 3, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter markdown conversion

2 participants