Remove damage number outline for Linux clients#651
Open
Tiagoquix wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the multitude of issues that apply to fonts on Linux (see SolarLightTF2/solarlighthud-redux#10 (comment)), especially in regards to outlines and (drop) shadows, the font used for damage numbers always looks a bit off because they are not properly rendered, in comparison with its Windows counterpart. It is the same font, but something in the Linux port makes it render bad. This is especially noticeable if you zoom-in more closely, and is noticeable during gameplay where you always feel something is wrong, even by a tiny bit.
This is also the reason as to why custom crosshairs with outlines or shadows do not work as good on Linux as they do on Windows, since font shadow/outline being rendered incorrectly (since custom crosshairs are a font hack into the HUD) makes them look bad.
This PR makes it so the damage numbers do not have any shadows or outlines, but only on Linux. Looks better to the eyes, since you stop noticing the jankiness of font outlines being rendered incorrectly. A FIXME comment is also added, in order to remove it in the future.
This is nothing to do with budhud itself, but rather due to how fonts are rendered.
Other parts of the HUD do not have such perceptible jankiness, since the HUD outlines/shadows render correctly in such parts. This is one of the most jarring ones, in my opinion.
Coincidentally, the default HUD is not affect, because damage numbers in the default HUD do not have any outlines or shadows.
Default combat text (with outline) on Linux. Zoom-in to notice the jarriness.
Drop shadow variant (a test, but it got even worse, IMO)
Variant without outline or shadow (this PR)