Skip to content

rauc.inc: add config for pkcs11_engine#411

Open
gumulka wants to merge 1 commit into
rauc:whinlatterfrom
gumulka:whinlatter
Open

rauc.inc: add config for pkcs11_engine#411
gumulka wants to merge 1 commit into
rauc:whinlatterfrom
gumulka:whinlatter

Conversation

@gumulka

@gumulka gumulka commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Add a PACKAGECONFIG option to en-/disable pkcs11_engine named engine, because it disables engine support for openssl, not pkcs11 support. It is enabled by default to have no disruption to previous versions

@ejoerns

ejoerns commented Feb 24, 2026

Copy link
Copy Markdown
Member

Add a PACKAGECONFIG option to en-/disable pkcs11_engine named engine, because it disables engine support for openssl, not pkcs11 support. It is enabled by default to have no disruption to previous versions

@gumulka I find the commit message quite hard to read. Maybe split up the sentence or at least set "engine" into quotes.

With the openssl context left out, I find it hard to tell what engine refers to, thus maybe something like openssl-engine for the config name?

If I'm not mistaken, this disables engine support for native and nativesdk which does not align well with the commit message.

Maybe also add a short note about the use case for this option.

Add a PACKAGECONFIG option to en-/disable pkcs11_engine.

It is named 'engine', because it disables engine support for openssl,
not pkcs11 support.

It is enabled by default to have no disruption to previous versions.

Signed-off-by: Fabian Pflug <f.pflug@pengutronix.de>
@ejoerns

ejoerns commented Apr 22, 2026

Copy link
Copy Markdown
Member

@gumulka I find the commit message quite hard to read. Maybe split up the sentence or at least set "engine" into quotes.

Thank you for splitting this up.

With the openssl context left out, I find it hard to tell what engine refers to, thus maybe something like openssl-engine for the config name?

I'd assume you intend to stay with this naming since you didn't change it?

If I'm not mistaken, this disables engine support for native and nativesdk which does not align well with the commit message.

I can't find this comment addressed. Am I mistaken here?

Maybe also add a short note about the use case for this option.

You don't find this necessary I guess?

@ejoerns

ejoerns commented Apr 22, 2026

Copy link
Copy Markdown
Member

@gumulka Also please target the master branch for new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants