Repository navigation
Conversation
…rks alone
An empty channel used to answer with ramped silence, the same as a channel
whose capture was still building. That is right for the second case and
wrong for the first. Dry signal under a capture that is about to land would
jump in level the moment the model arrived, so silence there is correct.
With nothing assigned, nothing is ever going to land: an instance loaded only
for its cabinet IR convolved silence, and a fresh instance with four empty
channels muted whatever it was placed in. The parent plug-in passes its input
through with no model loaded, and users run IR-only instances in chains with
other plug-ins on exactly that basis.
CrossfadeEngine now tells the two cases apart by the bank's count. No bank,
or the empty bank a Clear publishes, ramps a second gate, mDryMix, towards
1. A capture that is assigned but not built yet ramps it to 0, as before.
Both gates share mReadyStep, so neither transition clicks:
* nothing loaded -> capture loaded: the ready gate opens as the dry gate
closes underneath it, in the same chunk loop. chunkIn is still intact
there because the engine is never handed one buffer for input and
output. In steady state the dry gate is 0 and the loop does nothing;
* capture cleared -> nothing loaded: the ready gate closes and the dry
gate opens;
* mDryMix starts at 0, so a restored project that is still building never
lets a dry blip through first.
sounding() now counts the dry gate too. The rack uses it to decide whether
adopting a channel outright is free, and dry signal is audible.
The checks that assumed silence are updated:
* rations_ircheck gains a "no capture loaded" section. With every channel
and both IR slots cleared, the input comes out within 3 dB, which is
margin for the tone stack at its defaults. Loading one IR then changes
the samples and stays audible;
* rations_lv2check asserts pass-through with nothing loaded. Its bypass
check no longer works on its own, because bypass in and out now sound
the same, so it sets Output gain to its -40 dB floor first. Output gain
trims the wet path only, so bypass in must be at least 20x louder;
* comments in both products' processors, bank.h, toolcaptures.h, the two
midicheck tools, ir-gate.sh and the rations CMakeLists now describe the
new behaviour. Comments about a capture that is still building keep
saying ramped silence, because that is still what it gets.
Verified: by ear, in the standalone and the VST3. Nothing loaded passes the
guitar through. An IR alone sounds through the cabinet. Loading and clearing
a capture fade between dry and amp without a click. All six build
directories build with no errors and no warnings in our own code.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rks alone
An empty channel used to answer with ramped silence, the same as a channel whose capture was still building. That is right for the second case and wrong for the first. Dry signal under a capture that is about to land would jump in level the moment the model arrived, so silence there is correct. With nothing assigned, nothing is ever going to land: an instance loaded only for its cabinet IR convolved silence, and a fresh instance with four empty channels muted whatever it was placed in. The parent plug-in passes its input through with no model loaded, and users run IR-only instances in chains with other plug-ins on exactly that basis.
CrossfadeEngine now tells the two cases apart by the bank's count. No bank, or the empty bank a Clear publishes, ramps a second gate, mDryMix, towards
sounding() now counts the dry gate too. The rack uses it to decide whether adopting a channel outright is free, and dry signal is audible.
The checks that assumed silence are updated:
Verified: by ear, in the standalone and the VST3. Nothing loaded passes the guitar through. An IR alone sounds through the cabinet. Loading and clearing a capture fade between dry and amp without a click. All six build directories build with no errors and no warnings in our own code.