Repository navigation
Add fallback for mass-storage-gadget64 path - #405
Merged
Merged
Conversation
The install target places the boot files under share/rpiboot. Signed-off-by: Nicolai Buchwitz <n.buchwitz@kunbus.com>
Running an uninstalled build from outside the source tree fails because neither the install prefix nor the current directory holds the boot files. Fall back to the directory containing the rpiboot executable. Signed-off-by: Nicolai Buchwitz <n.buchwitz@kunbus.com>
Collaborator
|
Looks reasonable, I'll merge it untested (by me) since I know you will have tested it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We keep getting reports from customers that
rpiboot"doesn't work". Most of the time they built it themselves and run it from outside the project folder, sorpibootcan't find the boot files in the install prefix or the current directory.So maybe we can improve the UX and have a second fallback that also looks for
mass-storage-gadget64next to therpibootbinary. I also fixed the default path in the README while I was at it. It saidINSTALL_PREFIX/share/mass-storage-gadget64.