xTimerDelete in freertos deinit#3008
Open
peterharperuk wants to merge 1 commit into
Open
Conversation
kilograham
reviewed
Jun 15, 2026
kilograham
reviewed
Jun 15, 2026
| @@ -190,7 +195,6 @@ void async_context_freertos_deinit(async_context_t *self_base) { | |||
| if (self->task_complete_sem) { | |||
| vSemaphoreDelete(self->task_complete_sem); | |||
| } | |||
Contributor
There was a problem hiding this comment.
I mean it wasn't totally unnecessary; it made calling deinit multiple times ok (whether this is useful or not, i don't know)
Contributor
Author
There was a problem hiding this comment.
I've had a second attempt - just not clearing static memory.
In async_context_freertos_deinit we delete the timer, but the timer task might be running on the other core. So don't zero static memory as it might be in use. Fixes raspberrypi#2687
peterharperuk
force-pushed
the
freertos_deinit
branch
from
287f372 to
4168692
Compare
peterharperuk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2687