Update Clang toolchain used by Bazel#2879
Open
Prabhuk wants to merge 5 commits into
Open
Conversation
The Clang toolchain is updated to a newer revision 9431920bfaee50f4b1552fc01ea081a5c18a5a3b from March 20, 2026. Fixes raspberrypi#2859
|
Please do not submit against |
Author
lurch
reviewed
Jun 23, 2026
| # these are all the directories under LLVM embedded toolchain for ARM (newlib or picolibc) | ||
| set(PICO_CLANG_RUNTIMES armv8m.main_hard_fp armv8m.main_hard_fp_unaligned armv8m.main_hard_fp_unaligned_size) | ||
| set(PICO_CLANG_RUNTIMES armv8m.main_hard_fp armv8m.main_hard_fp_unaligned armv8m.main_hard_fp_unaligned_size armv8m.main-unknown-none-eabi) | ||
| message("ENABLING HARD FLOAT RUNTIME") |
Contributor
There was a problem hiding this comment.
Was this just a "testing print", which now ought to be removed?
will-v-pi
reviewed
Jun 24, 2026
| @@ -1,3 +1,5 @@ | |||
| set(PICO_HARD_FLOAT_ABI 1 CACHE BOOL "Use hard floating point ABI") | |||
Contributor
There was a problem hiding this comment.
This changes the default PICO_HARD_FLOAT_ABI for all Clang users, which I don't think is necessary for this PR - all the other Clang toolchains still support both hard and soft float ABIs, it's just the new Google toolchain that only supports hard float.
A better fix might be to remove armv8m.main-unknown-none-eabi from the softfp PICO_CLANG_RUNTIMES list, which should then throw the Could not find an llvm runtime error if PICO_HARD_FLOAT_ABI=0 (assuming support for the older soft float toolchain is not required).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Clang toolchain is updated to a newer revision 9431920bfaee50f4b1552fc01ea081a5c18a5a3b from March 20, 2026.
Fixes #2859