Fix compilation for PICO_BOARD=pico_w when cyw43_arch is missing#525
Fix compilation for PICO_BOARD=pico_w when cyw43_arch is missing#525lurch wants to merge 4 commits into
Conversation
|
pretty sure this is supposed to work so @peterharperuk may want to revist this |
|
If ${PICO_CYW43_DRIVER_PATH}/${CYW43_DRIVER_TEST_FILE} is missing then we don't add the cyw43_driver_picow library. If cyw43_driver_picow doesn't exist we don't add the pico_cyw43_arch library. We have this guarding the pico_w examples, so I guess we should have it here as well. if (PICO_CYW43_SUPPORTED) # set by PICO_BOARD=pico_w But having said that. I don't like the change. It looks brittle having the repetition in the cmake files. I'd rather just fix the examples to do the right thing. |
This comment was marked as abuse.
This comment was marked as abuse.
The issue will be fixed after this PR is merged, but we're still discussing the finer details 🙂 |
kilograham
left a comment
kilograham
left a comment
There was a problem hiding this comment.
marked as unapproved since there are comments
And address other build issues that occur if cyw43 is supported but the cyw43-driver does not exist.
peterharperuk
force-pushed
the
fix_picow_build
branch
from
0c88be2 to
5114e61
Compare
|
@kilograham I've addressed the comments for this and it seems to work now. |
| @@ -1,3 +1,6 @@ | |||
| if (PICO_CYW43_SUPPORTED AND NOT TARGET pico_cyw43_arch) | |||
| return() | |||
There was a problem hiding this comment.
why do some of these have a message (there is one without below too), and some not?
There was a problem hiding this comment.
So you don't see the same message repeatedly?
4 participants
Currently, if you try to build all of
pico-examplesfor the Pico W and you haven't yet init-ed thecyw43-driversubmodule inpico-sdk, then the build ofpico-exampleswill halt with a fatal build-error. This PR fixes that 🙂I'm not very familiar with CMake though, so perhaps there's a "neater" way of doing what I'm doing here?