fix(generate): only block genuinely headerless .wgt.csv at generate-level#197
Merged
Conversation
…evel #194 blocked ALL .wgt.csv at <generate>-level, merged before #196 (.wgt.csv accepts an optional header) landed. That makes it too strict now: a HEADERED .wgt.csv reads coherently through the plain CSV path (proper column names, just unweighted) - the same tolerance .wgt.ent.csv already gets. Only a genuinely headerless .wgt.csv has no coherent plain-CSV reading at all (first data row misread as a header, producing nonsense column names). Narrowed the guard to sniff the file's own first row (same check FileUtil.read_weight_csv itself uses to auto-detect a header) and only raise when there is no header to fall back on. Full suite 1442 passed/15 skipped, mypy/ruff clean.
_wgt_csv_has_header re-implemented the same float-parse try/except FileUtil._parses_as_float (from #196) already provides. One sniff, not two.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan