feat(provider-okx): add sui namespace#1444
Open
llawliet-l-l wants to merge 1 commit into
Open
Conversation
llawliet-l-l
requested review from
RyukTheCoder,
arlert-armin and
yeager-eren
as code owners
July 20, 2026 14:27
arlert-armin
requested changes
Jul 21, 2026
llawliet-l-l
force-pushed
the
feat/RC-307-adding-sui-to-okx
branch
from
July 22, 2026 10:56
8f0cf35 to
371d8b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Sui support to the OKX wallet provider. Sui is discovered through the wallet-standard registry (independent of OKX's injected instance map used by EVM/Solana/BTC), so it follows the wallet-standard pattern like the Slush/Phantom providers. Connect, account switch, wallet-side disconnect, eager connect, and transaction signing are all wired and verified on-device.
Changes
Suinamespace into the provider and registerDefaultSuiSigner(conditionally, since Sui comes from the registry rather than the injected map)Suimetadata entry and the wallet-standard name constantstandard:eventschangesubscriber; add a dedicated subscriber for wallet-side disconnect, which OKX emits as an (undocumented)disconnectevent on the samestandard:eventsfeature@rango-dev/signer-suidependency (Sui signer)Notes
disconnectevent onstandard:eventsthat isn't in the@mysten/wallet-standardtype (which only declareschange), so the disconnect subscriber casts.onto accept the extra event name (TS2345otherwise). The cast can be dropped if the event is ever added to the official types.How tested
eslint+yarn buildpass. Verified on-device with the OKX extension: connect, account switch, disconnect from the wallet UI, eager connect on reload, and a successful real Sui transaction signature.Known limitations