fix(docker): remove unpublished range42-deployer PyPI install from builder stage#83
Merged
Merged
Conversation
The pip install step was failing because range42-deployer is not published on PyPI. The CLI is also not invoked anywhere in the npm build pipeline, so it adds no value to the builder stage. Removes: python3/pip/venv apt install, pip install range42-deployer, DEPLOYER_CLI_VERSION build-arg, and ENV PATH override. Updates README to reflect the actual two-stage build flow. Fixes #42
t0kubetsu
force-pushed
the
feat/issue-42-docker-debian-stable
branch
from
94348f0 to
7706d76
Compare
The generate-pydantic.sh script exits 2 when datamodel-codegen is not on PATH. The venv install step was missing the package, causing PR #83 CI to fail at the "Regenerate Pydantic + drift check" step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #42 (docker build failing in builder stage).
Dockerfile:15-17attemptedpip install range42-deployerbutrange42-deployeris not published on PyPI — build always fails withNo matching distribution found.npm ci/npm run build), making the entire Python/venv block dead weight.Changes:
ARG DEPLOYER_CLI_VERSION,apt-get install python3/pip/venv,pip install range42-deployer, andENV PATHoverride from the builder stageCOPY package.json→npm ci→npm run buildTest plan
docker compose up --buildsucceeds anddocker compose psreportshealthycurl http://localhost:3000/healthreturnsokhttp://localhost:3000