Skip to content

Improvements for greater flexibility#70

Open
seirios wants to merge 3 commits into
raivokolde:masterfrom
seirios:master
Open

Improvements for greater flexibility#70
seirios wants to merge 3 commits into
raivokolde:masterfrom
seirios:master

Conversation

@seirios

@seirios seirios commented Jun 10, 2020

Copy link
Copy Markdown

This PR contains three improvements which I've found useful when using pheatmap.

  1. Honor number_format when using a matrix in display_numbers. This is technically a bugfix(?)
  2. Allow number_color to be a function, which allows setting text color based on background color. This is useful for getting good contrast against colormaps.
  3. Honor gaps_row/col settings when clustering rows/columns if cutree_rows/cols is unset. This allows for greater customization and doesn't hurt, right?

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant