fix: correct stale rainlang-0.1.2 import breaking the build on main#2737
Conversation
PR #2705 added test/concrete/parser/RaindexV6SubParser.routingTokenDecimalsAndMasks.t.sol importing from rainlang-0.1.2/, but foundry.toml pins rainlang = "0.1.5". forge soldeer install only fetches 0.1.5, so forge compile dies with "Source \"rainlang-0.1.2/src/error/ErrSubParse.sol\" not found", reddening copy-artifacts and rainix-sol/{static,test} on main HEAD and every PR inheriting it. Bump only the two import lines in that one file to the pinned 0.1.5 (the same src/error/ErrSubParse.sol and src/lib/parse/LibSubParse.sol paths exist there; ContextGridOverflow and LibSubParse are unchanged). No logic, no other file, no foundry.toml touched. src/lib/LibRaindexSubParser.sol already imports LibSubParse from rainlang-0.1.5 successfully, confirming 0.1.5 is correct. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 16 minutes and 38 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Reviewed 5a08983: corrects the stale rainlang-0.1.2 import (from #2705) that broke main's forge compile — copy-artifacts is now GREEN, confirming the fix. The remaining rainix-sol/static (multi-contract files → fixed by #2731) and rainix-sol/test (3 pre-existing OrderNoSources quote-test failures from #2701 → fixed separately) reds are pre-existing on main and NOT introduced by this 2-line, single-file, logic-free change (verified each). Strict improvement. LGTM. |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
Why main is red
mainHEAD is red oncopy-artifacts,rainix-sol / static, andrainix-sol / test. PR #2705 (commit9b9259370, already merged to main) addedtest/concrete/parser/RaindexV6SubParser.routingTokenDecimalsAndMasks.t.sol, which imports fromrainlang-0.1.2/:But
foundry.tomlpinsrainlang = "0.1.5". Soforge soldeer installnever fetches0.1.2, and the whole forge compile dies with:A failed compile reddens
copy-artifacts+rainix-sol/{static,test}on main HEAD and on every PR that inherits this commit.The fix
Bump only those two import lines in that one file to the pinned
0.1.5:0.1.5is the correct version: the samesrc/error/ErrSubParse.solandsrc/lib/parse/LibSubParse.solpaths exist in the installed0.1.5dep (ContextGridOverflowandLibSubParse.subParserContextare unchanged), andsrc/lib/LibRaindexSubParser.solon main already importsLibSubParsefromrainlang-0.1.5/src/lib/parse/LibSubParse.solsuccessfully.This greens
copy-artifacts+rainix-sol/{static,test}on main and unblocks all inheriting PRs.Scope
2-line, single-file, logic-free fix. No other file, no
foundry.toml, no logic touched.Verification (under
nix develop github:rainlanguage/rainix#sol-shell)forge buildnow compiles cleanly (was dying with thenot founderror).copy-artifactssequence (build-meta.sh→BuildPointers.sol→forge build→script/build.sh→forge fmt) produces no artifact drift —git statusshows only the one import file changed.forge test --match-path 'test/concrete/parser/RaindexV6SubParser.routingTokenDecimalsAndMasks.t.sol'→ 4 passed, 0 failed.🤖 Generated with Claude Code