Skip to content

fix: correct stale rainlang-0.1.2 import breaking the build on main#2737

Merged
thedavidmeister merged 1 commit into
mainfrom
2026-06-13-fix-stale-rainlang-import
Jun 14, 2026
Merged

fix: correct stale rainlang-0.1.2 import breaking the build on main#2737
thedavidmeister merged 1 commit into
mainfrom
2026-06-13-fix-stale-rainlang-import

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

Why main is red

main HEAD is red on copy-artifacts, rainix-sol / static, and rainix-sol / test. PR #2705 (commit 9b9259370, already merged to main) added test/concrete/parser/RaindexV6SubParser.routingTokenDecimalsAndMasks.t.sol, which imports from rainlang-0.1.2/:

import {ContextGridOverflow} from "rainlang-0.1.2/src/error/ErrSubParse.sol";
import {LibSubParse} from "rainlang-0.1.2/src/lib/parse/LibSubParse.sol";

But foundry.toml pins rainlang = "0.1.5". So forge soldeer install never fetches 0.1.2, and the whole forge compile dies with:

Source "rainlang-0.1.2/src/error/ErrSubParse.sol" not found

A failed compile reddens copy-artifacts + rainix-sol/{static,test} on main HEAD and on every PR that inherits this commit.

The fix

Bump only those two import lines in that one file to the pinned 0.1.5:

import {ContextGridOverflow} from "rainlang-0.1.5/src/error/ErrSubParse.sol";
import {LibSubParse} from "rainlang-0.1.5/src/lib/parse/LibSubParse.sol";

0.1.5 is the correct version: the same src/error/ErrSubParse.sol and src/lib/parse/LibSubParse.sol paths exist in the installed 0.1.5 dep (ContextGridOverflow and LibSubParse.subParserContext are unchanged), and src/lib/LibRaindexSubParser.sol on main already imports LibSubParse from rainlang-0.1.5/src/lib/parse/LibSubParse.sol successfully.

This greens copy-artifacts + rainix-sol/{static,test} on main and unblocks all inheriting PRs.

Scope

2-line, single-file, logic-free fix. No other file, no foundry.toml, no logic touched.

Verification (under nix develop github:rainlanguage/rainix#sol-shell)

  • Full forge build now compiles cleanly (was dying with the not found error).
  • Full copy-artifacts sequence (build-meta.shBuildPointers.solforge buildscript/build.shforge fmt) produces no artifact drift — git status shows only the one import file changed.
  • forge test --match-path 'test/concrete/parser/RaindexV6SubParser.routingTokenDecimalsAndMasks.t.sol' → 4 passed, 0 failed.

🤖 Generated with Claude Code

PR #2705 added test/concrete/parser/RaindexV6SubParser.routingTokenDecimalsAndMasks.t.sol
importing from rainlang-0.1.2/, but foundry.toml pins rainlang = "0.1.5".
forge soldeer install only fetches 0.1.5, so forge compile dies with
"Source \"rainlang-0.1.2/src/error/ErrSubParse.sol\" not found", reddening
copy-artifacts and rainix-sol/{static,test} on main HEAD and every PR inheriting it.

Bump only the two import lines in that one file to the pinned 0.1.5 (the same
src/error/ErrSubParse.sol and src/lib/parse/LibSubParse.sol paths exist there;
ContextGridOverflow and LibSubParse are unchanged). No logic, no other file,
no foundry.toml touched. src/lib/LibRaindexSubParser.sol already imports
LibSubParse from rainlang-0.1.5 successfully, confirming 0.1.5 is correct.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this Jun 13, 2026
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@thedavidmeister, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 16 minutes and 38 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9f378243-af62-4db1-8560-4eea91e2b32d

📥 Commits

Reviewing files that changed from the base of the PR and between 31e7a49 and 5a08983.

📒 Files selected for processing (1)
  • test/concrete/parser/RaindexV6SubParser.routingTokenDecimalsAndMasks.t.sol
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-06-13-fix-stale-rainlang-import

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thedavidmeister

Copy link
Copy Markdown
Contributor Author

Reviewed 5a08983: corrects the stale rainlang-0.1.2 import (from #2705) that broke main's forge compile — copy-artifacts is now GREEN, confirming the fix. The remaining rainix-sol/static (multi-contract files → fixed by #2731) and rainix-sol/test (3 pre-existing OrderNoSources quote-test failures from #2701 → fixed separately) reds are pre-existing on main and NOT introduced by this 2-line, single-file, logic-free change (verified each). Strict improvement. LGTM.

@thedavidmeister thedavidmeister merged commit 733e0b5 into main Jun 14, 2026
14 of 16 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant