Skip to content

document the safeTransfer self-flow branch in LibFlow.flowERC20 NatSpec #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thedavidmeister merged 2 commits into from
Jun 13, 2026
+5 −2
Merged

document the safeTransfer self-flow branch in LibFlow.flowERC20 NatSpec #468

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6759cb6
document the safeTransfer self-flow branch in LibFlow.flowERC20 NatSpec
thedavidmeister May 7, 2026
7e5c79b
Merge origin/main into 2026-05-07-issue-379-libflow-erc20-natspec
claude Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/lib/LibFlow.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,11 @@ library LibFlow {

/// Processes the ERC20 transfers in the flow.
/// Reverts if the `from` address is not either the `msg.sender` or the
/// flow contract. Uses `IERC20.safeTransferFrom` to transfer the tokens to
/// ensure that reverts from the token are respected.
/// flow contract. Uses `IERC20.safeTransferFrom(from, to, amount)` when
/// `from == msg.sender` and `IERC20.safeTransfer(to, amount)` when
/// `from == address(this)` — the self-flow branch must use
/// `safeTransfer` because OZ `transferFrom` consumes allowance even
/// when `from == msg.sender`. Both branches surface token reverts.
/// @param flowTransfer The `FlowTransferV1` to process. Tokens other than
/// ERC20 tokens are ignored.
function flowERC20(FlowTransferV1 memory flowTransfer) internal {
Expand Down
Loading