[Fix] Correct adjoint matrix block order to match (v, ω) twist definition#37
[Fix] Correct adjoint matrix block order to match (v, ω) twist definition#37ht-Leung wants to merge 1 commit into
Conversation
|
Thanks for the PR, I think you are right, however the real issue is that we used delta pose control for low-level controller in Franka (https://github.com/rail-berkeley/serl_franka_controllers) rather than twist as in this code. So I think the fix would be:
|
|
Got it, thanks for clarifying — that makes sense! |
|
Yes, however it does make a difference if you switch to a different type of controller, sorry for the confusion, this is mostly a problem on our side. In your PR, the codebase will be doing twist control, then you would need to perform twist control on the low level It will make a significant difference if the robot's movement involves rotation |
|
Thanks for the explanation — that clears it up! My PR just fixes the adjoint matrix definition to match the (v, ω) convention, so it doesn’t change how control is actually applied. Once the controller side is unified, this should stay consistent geometrically. Appreciate the context. I’ll stay in sync with #39 then. Also, really appreciate the great work from Prof. Luo and the HIL-SERL team — the real-world RL system is impressively robust and well-engineered. The stability and performance of your setup are honestly remarkable! |
Summary
This PR fixes the adjoint matrix definition to match the twist ordering (v, ω) used in the environment.
Details
[p]_× Rto the upper-right block.Related Issue
Fixes #36