Require verified email for external launches#106
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe external module launch route gains a 403 guard that blocks token issuance when ChangesEmail Verification Gate for External Module Launch
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR tightens the signed external module launch flow by requiring a verified account email before issuing a launch token when the module is configured to include the user’s email claim.
Changes:
- Enforce
emailVerifiedAtfor module launches whenincludeEmailInLaunchis enabled (returns 403 otherwise). - Update launch token signing to only include
emailwhen the user’s email is verified. - Extend the E2E suite and integration guide to cover/describe the new verification requirement.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/e2e/app.spec.ts | Adds an E2E case ensuring unverified users receive 403 when launching modules that include email in launch claims. |
| src/app/(frontend)/api/modules/[slug]/launch/route.ts | Blocks unverified-email launches for includeEmailInLaunch modules and conditions the email claim on verification. |
| docs/external-module-integration-guide.md | Documents the verified-email requirement for includeEmailInLaunch launches. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary by CodeRabbit
Bug Fixes
Documentation