feat(popper)!: thin positioners — single-source inputs, unified CSS vars, z-index decoupling (ADR 0012)#419
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
⚡ PerformanceTotal duration: 136.1 ms +2.4 ms (+1.8%) · Renders: 13 (-3) · Paint: 167.9 ms +6.4 ms (+4.0%)
2 tests within noise
Lower is better. ▲ regression · ▼ improvement · within-noise = |Δ| ≤ 20% of base median. |
The wrapper no longer copies the popup's computed z-index onto the positioner. Drop `contentChild.required(RdxPopperContent)`, `contentZIndex`, and the `zIndex` entry from `RdxPopperContentWrapper.style()` (plus the now-unused isBrowser/PLATFORM_ID/RdxPopperContent imports). z-index now belongs on the positioner, Base UI-aligned — and a positioner no longer requires an inner `RdxPopperContent` to exist (the open-time query crash and the getComputedStyle-in-change-detection both go away). In-repo sweep of load-bearing popup z-index → positioner: demoCombobox (combobox + autocomplete) and the 4 popper-mode select stories; the 2 item-aligned select stories were never copied and are left as-is. BREAKING CHANGE: set the stacking `z-index` on the popper positioner element, not the popup. Consumers who set `z-*` on the popup (relying on the wrapper copying it onto the positioner) must move that class up one element to the positioner.
pimenovoleg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description