FRA-2021: Escape non-ascii characters#619
Merged
alanjcharles14 merged 4 commits intoJun 10, 2026
Merged
Conversation
alanjcharles14
commented
Jun 9, 2026
| #expect(decoded?["name"] == "Café") | ||
| } | ||
|
|
||
| @Test func escapeNonAsciiHandlesEmojiSurrogatePairs() throws { |
Contributor
Author
There was a problem hiding this comment.
probably not strictly necessary, but fun
Contributor
|
@alanjcharles14 did we test against the server with an escaped name? Just to confirm e2e behavior? Otherwise lgtm |
Contributor
Author
|
@lmeier seems unnecessary since the server is just parsing the json which is functionally equivalent to what the tests here are doing. running this in a terminal shows that it was handled correctly on the server already and handles the new fix though: |
lmeier
approved these changes
Jun 10, 2026
…-in-app-name-causes-error_server-and
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Escapes any non-ASCII character in the header value to a JSON
\uXXXXsequence so the value is always ASCII-safe, while remaining valid JSON that the backend decodes identically.