consolidate geofence swift#604
Merged
Merged
Conversation
stevepopovich
previously approved these changes
May 21, 2026
stevepopovich
left a comment
stevepopovich
left a comment
Contributor
There was a problem hiding this comment.
Is there an attached ticket? Looks legit though
| import CoreLocation | ||
| import Foundation | ||
|
|
||
| struct RadarCoordinateSwift: Codable, Sendable { |
Contributor
There was a problem hiding this comment.
So this just implements == implicitly right?
Contributor
Author
There was a problem hiding this comment.
yeah, adding Equatable automatically implements == since everyfield of this class is equatable.
Contributor
|
@ShiCheng-Lu happy to re-approve once the linter is happy. Would do it now but it'll just get dismissed I think |
alanjcharles14
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we had RadarGeofenceSwift for event sync and RadarGeofence_Swift for notifications, RadarGeofenceSwift was missing metadata, added that so it can be consolidated.
see #569
The other PR got a little messy with merge conflicts, so I've re-done the consolidation on main.
https://linear.app/radarlabs/issue/FENCE-2853/swift-geofence-clean-up