Fraud sdk configuration#546
Draft
ShiCheng-Lu wants to merge 9 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the SDK to support fraud/ping server configuration during initialization and wires the Fraud framework into the example project.
Changes:
- Add
pingServerConfigurationtoRadarMetaand parse it from config responses. - Trigger
RadarSDKFraudstartup duringRadarinitialization when ping server configuration is present. - Update the Example Xcode project to link/embed
RadarSDKFraud.framework(and refactor framework references).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| RadarSDKFraud | Bumps the Fraud submodule pointer to a newer commit. |
| RadarSDK/RadarMeta.m | Parses pingServerConfiguration from the meta dictionary. |
| RadarSDK/RadarMeta.h | Exposes pingServerConfiguration on RadarMeta. |
| RadarSDK/Radar.m | Starts Fraud SDK based on meta config; adds logging/imports. |
| RadarSDK/Include/RadarSDKFraudProtocol.h | Adds a +start: API for Fraud config initialization. |
| Example/Example.xcodeproj/project.pbxproj | Links/embeds RadarSDKFraud.framework and restructures project references. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| if (config.meta.pingServerConfiguration) { | ||
| Class RadarSDKFraud = NSClassFromString(@"RadarSDKFraud"); | ||
| if (RadarSDKFraud != nil) { |
There was a problem hiding this comment.
This dynamically calls +start: on a Class without verifying the selector exists. If a class named RadarSDKFraud is present but doesn’t implement +start:, this will raise an unrecognized selector exception. Add a respondsToSelector:@selector(start:) check (and optionally confirm conformance to RadarSDKFraudProtocol) before calling.
Suggested change
| if (RadarSDKFraud != nil) { | |
| if (RadarSDKFraud != nil && [RadarSDKFraud respondsToSelector:@selector(start:)]) { |
ShiCheng-Lu
commented
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.