Dictation follow-up: Saved dictation title test, passing notes, Quit flag - #1824
Merged
Merged
Conversation
…flag - Test the "Saved dictation" import title through the public prepareImportedAudio path (and that a lookalike filename keeps its name). - A press waiting for the next take may start over a passing note about a take that went fine (no speech heard, "Pasted. Press Return to send it."). Failures and copy-only notices still hold it back. - Quit's no-new-take flag stays set once Quit is admitted; every refusal clears it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RpbEynta8Qgv2RiZMg4nUu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Justin · project thread
Before: After #1819, a dictation shortcut press made while the last take was finishing was quietly dropped if that take ended with a harmless note ("Pasted. Press Return to send it." or the brief "No speech heard"). The flag that stops presses from queuing during Quit also cleared as soon as Quit was admitted, before the app had actually closed. Nothing tested the new "Saved dictation" import title.
After: A waiting press starts over those passing notes. Failures and "copied, press ⌘V" notices still hold it back. Once Quit is admitted the flag stays set, and every refusal clears it. The title has a test.
How:
FloatingOverlayController.messageCanGiveWayToNextStartis set byshowNoSpeechAndDismissand by the controller after the Press Return notice, and cleared by every other message.finishDictationForTerminationclearsisTerminatingDictationon each false return (and inadmitInactiveDictationQuitwhen it refuses) instead of in adefer. The new test goes throughprepareImportedAudio, and also checks that a lookalike filename keeps its own name.These are the non-blocking follow-ups from the #1819 review (reviews/next-release/1819.md). Hold the merge until the 1.1.63 RC is cut: main is frozen.
Why
Leftovers from the #1819 deep review.
Product Impact
dictationdictation reliabilityWhat changed
Sources/UI/Overlay/FloatingOverlayController.swift,DictationSessionController.swiftMeetingImportedAudioPreparerTests.swift,DictationQueuedStartPolicyTests.swiftHow I checked it
bash scripts/dev/linux-checks.sh(49 passed)bash build.sh --no-open/bash run-tests.sh: CI (no Swift toolchain in this session)Risk Review
Agent handoff
COORD_DONE: BRIEF | this PR | 3 small #1819 follow-ups | none | hold merge until RC cut | linux-checks | CI + deep review🤖 Generated with Claude Code
https://claude.ai/code/session_01RpbEynta8Qgv2RiZMg4nUu
Generated by Claude Code