Skip to content

swap callback patch#101

Open
ernstnaezer wants to merge 1 commit into
quirkey:masterfrom
ernstnaezer:2049e098caef4b9766221af7428e3872f56d29a4
Open

swap callback patch#101
ernstnaezer wants to merge 1 commit into
quirkey:masterfrom
ernstnaezer:2049e098caef4b9766221af7428e3872f56d29a4

Conversation

@ernstnaezer

Copy link
Copy Markdown

Added callback support for the swap function, this allows code to be executed after a fadeout / fadein sequence when the html is in place.

…executed after a fadeout / fadein sequence when the html is in place.
@quirkey

quirkey commented Nov 15, 2011

Copy link
Copy Markdown
Owner

I want to take this work in, but you need to do a bunch of cleanup first. First of all, fix up all the spacing so its consistent. This project uses 2 soft-tabs (spaces) for indentation. Also, for the benefit of consistency and linting, please wrap all if statements in {}. Additionally, it would be great to get some even very simple tests for this in the test suite, especially with the code related to partial() since thats such an overloaded method already.

Thanks!

quirkey pushed a commit that referenced this pull request Jan 22, 2012
Based on enix's patch, cleaned it up and fixed a couple minor issues
@s7726

s7726 commented May 26, 2018

Copy link
Copy Markdown

@quirkey Looks like you merged in an equivalent commit. Can we get this pull request closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants