Repository navigation
Publish the newer of the source and stored ACME serials (0.6.4) - #16
Merged
Merged
Conversation
with_acme_overlay replaced an ACME-managed zone's SOA serial with the stored acme-serials value unconditionally. After an operator edit with a higher serial, the primary kept publishing the older ACME serial, so secondaries never transferred the change and deployments that wait for the new serial failed. Keep the newer of the two in RFC 1982 order; the next ACME update already advances past both through next_serial. Found in production: devreal.ai at 2026091201 in the source data kept publishing 2026081503 from acme-serials. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cs9W8zZ4hWHGUfoQEydTab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug.
Zone::with_acme_overlayreplaced an ACME-managed zone's SOA serial with the storedacme-serialsvalue unconditionally. After an operator edit that raised the source serial, the primary kept publishing the older ACME serial, so secondaries never transferred the change. Deployments that wait for the new serial also fail.Seen in production on a.ns.cron.sh: devreal.ai at
2026091201inrgbdns.datakept publishing2026081503fromacme-serials, and the cronsh deploy stopped at "Wait for primary publication".Fix. Publish the newer of the two serials in RFC 1982 order (
newer_serial). ACME updates are unchanged:next_serialalready advances past both the stored and the source serial.Release. Patch release 0.6.4, with versions synced as in the 0.6.3 release: Cargo, Debian, RPM, man pages, docs, changelogs.
Tests. A new unit test covers an operator edit newer than the stored serial, ACME updates newer than the source, equal serials, and wrap-around. Local runs of
cargo fmt --check,cargo clippy --all-targets -- -D warnings,cargo test --all-targets(93 passed),packaging/tests/test-secondary-sync.shandgit diff --checkall pass.make -C ietf checkdoes not apply: no protocol or draft change.🤖 Generated with Claude Code
https://claude.ai/code/session_01Cs9W8zZ4hWHGUfoQEydTab