chore: Add arm64 supported label in CSO CSV [PROJQUAY-9888]#160
Conversation
WalkthroughAdds arm64 architecture support metadata to the ClusterServiceVersion manifest by including Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
bundle/manifests/container-security-operator.clusterserviceversion.yaml (1)
22-27:⚠️ Potential issue | 🔴 CriticalCRITICAL: arm64 label added without corresponding image support.
The
operatorframework.io/arch.arm64: supportedlabel is correctly formatted and follows the existing pattern, but there's a critical mismatch: the container images are not being built for arm64.The build script at lines 64 and 87 explicitly limits the build platform to
linux/amd64,linux/s390x,linux/ppc64leonly. No arm64 images are being built or published. This means the operator will fail to schedule on arm64 nodes with a pull error.Either add arm64 to the build platforms in hack/build.sh (lines 64 and 87), or remove the arm64 label from the CSV. Do not claim architecture support without building images for that architecture.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bundle/manifests/container-security-operator.clusterserviceversion.yaml` around lines 22 - 27, The CSV declares operatorframework.io/arch.arm64: supported but the build script hack/build.sh only builds images for linux/amd64,linux/s390x,linux/ppc64le; fix by either adding linux/arm64 to the platforms variable/flags used by the image build/push steps in hack/build.sh (the PLATFORMS or docker buildx --platform setting used for image builds) so arm64 images are produced and published, or remove the operatorframework.io/arch.arm64: supported label from container-security-operator.clusterserviceversion.yaml so the CSV no longer claims arm64 support.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@bundle/manifests/container-security-operator.clusterserviceversion.yaml`:
- Around line 22-27: The CSV declares operatorframework.io/arch.arm64: supported
but the build script hack/build.sh only builds images for
linux/amd64,linux/s390x,linux/ppc64le; fix by either adding linux/arm64 to the
platforms variable/flags used by the image build/push steps in hack/build.sh
(the PLATFORMS or docker buildx --platform setting used for image builds) so
arm64 images are produced and published, or remove the
operatorframework.io/arch.arm64: supported label from
container-security-operator.clusterserviceversion.yaml so the CSV no longer
claims arm64 support.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fbbbede7-a1c3-429e-96d1-280678c7743e
📒 Files selected for processing (1)
bundle/manifests/container-security-operator.clusterserviceversion.yaml
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Tests
|
/cherrypick redhat-3.17 |
|
@dongboyan77: new pull request created: #161 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Add arm64 supported label in CSV, then openshift UI could display operator info