Fix first character of non-code lines highlighted as a comment - #1155
Merged
juliasilge merged 4 commits intoSep 30, 2026
Merged
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
juliasilge
requested changes
Sep 29, 2026
juliasilge
left a comment
juliasilge
left a comment
Collaborator
There was a problem hiding this comment.
Thank you so much for this contribution! I think we still have a problem with magics, but with a bit of followup, this will be good to go. 🙌
The virtual doc replaces IPython magic lines (`%`, `%%`, `!`) with `#` filler, but the semantic tokens provider treated every line between the fences as code, so comment tokens on that filler were applied to the real document (#985 inside a code cell). `virtualDocForLanguage` now returns `codeLines`, the lines it filled with real code, so the vdoc builder owns the rule. `unadjustedSemanticTokens` takes the lines as a required parameter. Tests go through `embeddedSemanticTokensProvider` with a fake python provider, covering YAML, prose, fences, an R cell and magic lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…iller-lines # Conflicts: # apps/vscode/CHANGELOG.md
Contributor
Author
|
Thanks for the review! Updated:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #985.
Semantic tokens for code cells come from a virtual doc where every non-cell line is a
#filler.Language servers that emit comment tokens colored the first character of each paragraph, heading and YAML line as a comment.
Now only tokens on lines inside the language's code cells are kept.
This also drops tokens on the virtual doc's injected header lines (e.g.
# type: ignore), which mapped to negative lines and made the provider throw, losing semantic highlighting for Python cells.Adds a unit test for
unadjustedSemanticTokens.