Repository navigation
Q-20-2: quote only pandoc's version line in the too-old message - #1108
Merged
Merged
Conversation
The message quoted the whole `pandoc --version` stdout with `{:?}`, so it
showed every feature line plus escaped `\r\n` on Windows:
pandoc reported version "pandoc.exe 3.5\r\nFeatures: +server +lua\r\n...",
which is older than the minimum required version 3.12.
It now quotes the first line: pandoc reported version "pandoc.exe 3.5".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Q-20-2 "Pandoc Version Too Old" message quoted the whole
pandoc --versionstdout, so on Windows it read:It now quotes only the first line:
pandoc reported version "pandoc.exe 3.5", which is older than the minimum required version 3.12.Added a unit test (fails before the fix, passes after).
cargo test -p quarto-core --lib pandoc_filters::versionandcargo clippy -p quarto-core --all-targets -- -D warningspass. I didn't rebuild theq2binary to check the message end to end.