Create qcom-preflight-checks.yml#14
Closed
Sandhya1236 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Sandhya Adavikolanu <sadaviko@qti.qualcomm.com>
30785b2 to
9a3279d
Compare
Member
|
@Sandhya1236 this TF-A repo is fork of upstream TF-A repo which exists here: https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/. So the pre-flight checks shouldn't be needed on this fork. |
Yep @Sandhya1236 we should skip for forks, I guess it's not immediately clear this is a fork via the UI since it's missing the GitHub fork link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced QC Preflight Checks Workflow
Introduced the QC Preflight Checks GitHub Actions workflow with the following updates and configurations:
Added the QC Preflight Checks workflow
Configured the workflow trigger to use pull_request instead of pull_request_target
(Security improvement: pull_request_target runs with write permissions and access to secrets, which is unsafe for untrusted PRs)
Integrated the v2 version of the reusable workflow (qcom-reusable-workflow)
Defined a single job named preflight
Added job display name: Run QC Preflight Checks
Adopted the new v2 input parameter format:
enable-semgrep-scan
enable-dependency-review
enable-repolinter-check
enable-copyright-license-check
enable-commit-email-check
enable-commit-msg-check
enable-armor-checkers
Removed SEMGREP_APP_TOKEN secret, as it is no longer required in v2
Enabled Checks
Only the following checks are enabled:
enable-repolinter-check: true
enable-commit-email-check: true
All other checks are explicitly disabled.
For more details, refer to the https://github.com/qualcomm/qcom-reusable-workflows