Skip to content

chore(eval): label doctor MR 71 findings #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qiankunli wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(eval): label doctor MR 71 findings #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions eval/labels/epscp-doctor.jsonl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{"fingerprint": "e6c364809d35", "label": "minor", "note": "Python probe 对 top_streams 始终写入 length，类型应收敛为必填 nullable，采纳修复。", "tags": [], "path": "cli/src/collect/redis/model.ts", "line": 39, "source": "gitlab:code.byted.org/epscp/doctor!71", "comment_url": "https://code.byted.org/epscp/doctor/-/merge_requests/71#note_785317428729857", "reply_id": 785321620937819, "by": "liqiankun.1111", "at": "2026-07-14T03:35:30.000Z"}
{"fingerprint": "2c7b49e4e948", "label": "important", "note": "prefix 是 Redis key 派生的外部输入，反引号或表格分隔符会破坏 Markdown，采纳统一 inline-code 转义。", "tags": [], "path": "cli/src/collect/redis/render.ts", "line": 100, "source": "gitlab:code.byted.org/epscp/doctor!71", "comment_url": "https://code.byted.org/epscp/doctor/-/merge_requests/71#note_785317428752894", "reply_id": 785321620960252, "by": "liqiankun.1111", "at": "2026-07-14T03:35:31.000Z"}
{"fingerprint": "a1ed58124631", "label": "important", "note": "big key 名开启 show-key-names 后可含反引号，确会破坏 code span，采纳统一 inline-code 转义。", "tags": [], "path": "cli/src/collect/redis/render.ts", "line": 117, "source": "gitlab:code.byted.org/epscp/doctor!71", "comment_url": "https://code.byted.org/epscp/doctor/-/merge_requests/71#note_785317428730971", "reply_id": 785321623072821, "by": "liqiankun.1111", "at": "2026-07-14T03:35:31.000Z"}
{"fingerprint": "fb54cf061ab0", "label": "important", "note": "stream key 与 big key 同属外部输入，确有相同 Markdown code span 问题，采纳统一修复。", "tags": [], "path": "cli/src/collect/redis/render.ts", "line": 123, "source": "gitlab:code.byted.org/epscp/doctor!71", "comment_url": "https://code.byted.org/epscp/doctor/-/merge_requests/71#note_785317430820996", "reply_id": 785321623138357, "by": "liqiankun.1111", "at": "2026-07-14T03:35:32.000Z"}
{"fingerprint": "a7216e14c9f9", "label": "minor", "note": "当前调用方始终传齐字段，不是运行时缺陷；但 Record<string, unknown> 丢失了 renderer 契约，采纳领域 target 类型。", "tags": [], "path": "cli/src/collect/redis/render.ts", "line": 39, "source": "gitlab:code.byted.org/epscp/doctor!71", "comment_url": "https://code.byted.org/epscp/doctor/-/merge_requests/71#note_785317432941259", "reply_id": 785321623042701, "by": "liqiankun.1111", "at": "2026-07-14T03:35:32.000Z"}
{"fingerprint": "7ae564942cc1", "label": "important", "note": "detector 已在 try 内，但 renderer 仍可能抛错并绕过 finish；应统一进入诊断失败交付路径，采纳修复。", "tags": [], "path": "cli/src/collect/redis.ts", "line": 459, "source": "gitlab:code.byted.org/epscp/doctor!71", "comment_url": "https://code.byted.org/epscp/doctor/-/merge_requests/71#note_785317432934632", "reply_id": 785321625132123, "by": "liqiankun.1111", "at": "2026-07-14T03:35:32.000Z"}
{"fingerprint": "49e45331dfc2", "label": "minor", "note": "项目没有禁止 nested ternary 的明文规则，但三格式标签用映射更清晰，采纳小改。", "tags": [], "path": "cli/src/collect/redis.ts", "line": 319, "source": "gitlab:code.byted.org/epscp/doctor!71", "comment_url": "https://code.byted.org/epscp/doctor/-/merge_requests/71#note_785317432940624", "reply_id": 785321625147784, "by": "liqiankun.1111", "at": "2026-07-14T03:35:33.000Z"}
{"fingerprint": "dc064c6550a7", "label": "wrong", "note": "#textbook displaySummary 是 HTML 人类展示覆盖，reportData 对应“导出原始 JSON”，故意保留含 TTL 表格的 canonical summary；两者不同是产品语义而非不一致。", "tags": ["textbook"], "path": "cli/src/collect/output/html.ts", "line": 63, "source": "gitlab:code.byted.org/epscp/doctor!71", "comment_url": "https://code.byted.org/epscp/doctor/-/merge_requests/71#note_785317435038088", "reply_id": 785321625165641, "by": "liqiankun.1111", "at": "2026-07-14T03:35:33.000Z"}
{"fingerprint": "e9bd9ff2211e", "label": "important", "note": "dbsize 是新增的附加观测，不应因其失败丢掉已可获取的 INFO；master/replica 都应降级为 null，采纳修复。", "tags": [], "path": "cli/src/collect/redis_probe.py", "line": 284, "source": "gitlab:code.byted.org/epscp/doctor!71", "comment_url": "https://code.byted.org/epscp/doctor/-/merge_requests/71#note_785317435037776", "reply_id": 785321627230300, "by": "liqiankun.1111", "at": "2026-07-14T03:35:33.000Z"}