Repository navigation
fix(script): keep Defi bundle name during install transaction - #149
Merged
Merged
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This narrowly fixes the temporary bundle paths used during installation so macOS preserves the Defi bundle name, while leaving the final install location and service lifecycle unchanged. The change is localized to the installer transaction and is straightforward to verify. You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Source installs (
script/build_and_run.sh) moved the installed bundle to.Defi-install.XXXX/previous.appbefore replacing it. LaunchServices follows moved bundles, so System Settings could list Defi's Accessibility and Screen Recording entries as previous, permanently so when a failed install retained its recovery bundle.Fix
Keep the
Defi.appfile name for both transaction bundles:previous/Defi.appandcandidate/Defi.app. Bundle identifier and code signature are unchanged, so existing permissions stay valid.Release installs (Homebrew, ZIP) are unaffected: packaging only uses
--stage.Verification
python3 script/verify.py localpassed, including the failed-install recovery workflow test.Note
Keep Defi bundle name during install transaction
The installer previously staged bundles under generic names, which broke the .app naming during install. This change stages previous and candidate bundles at paths that include the application name and
.appsuffix.finish_install; check that path matches the new layoutMacroscope summarized 3d3c5ad.