Skip to content

fix(script): keep Defi bundle name during install transaction - #149

Merged
qeude merged 1 commit into
mainfrom
fix/install-bundle-name
Oct 24, 2026
Merged

qeude merged 1 commit into
mainfrom
fix/install-bundle-name

Conversation

@qeude

@qeude qeude commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Problem

Source installs (script/build_and_run.sh) moved the installed bundle to .Defi-install.XXXX/previous.app before replacing it. LaunchServices follows moved bundles, so System Settings could list Defi's Accessibility and Screen Recording entries as previous, permanently so when a failed install retained its recovery bundle.

Fix

Keep the Defi.app file name for both transaction bundles: previous/Defi.app and candidate/Defi.app. Bundle identifier and code signature are unchanged, so existing permissions stay valid.

Release installs (Homebrew, ZIP) are unaffected: packaging only uses --stage.

Verification

  • python3 script/verify.py local passed, including the failed-install recovery workflow test.
  • Desktop installation not run.

View guided diff Turn on auto-fix

Note

Keep Defi bundle name during install transaction

The installer previously staged bundles under generic names, which broke the .app naming during install. This change stages previous and candidate bundles at paths that include the application name and .app suffix.

  • Creates separate previous and candidate directories inside the transaction before install proceeds in build_and_run.sh
  • Rollback restores the previous bundle from the new filename-preserving path
  • Candidate copy, code-signature verification, and the replacement moves all use the new named paths
  • Risk: rollback detection now depends on the previous-bundle path in finish_install; check that path matches the new layout

Macroscope summarized 3d3c5ad.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

View guided diff | Turn on auto-fix | Re-trigger cubic

@macroscopeapp

macroscopeapp Bot commented Oct 20, 2026

Copy link
Copy Markdown

Approvability

Verdict: Approved at 3d3c5ad

Macroscope's review found this PR approvable — This narrowly fixes the temporary bundle paths used during installation so macOS preserves the Defi bundle name, while leaving the final install location and service lifecycle unchanged. The change is localized to the installer transaction and is straightforward to verify.

You can add or adjust custom eligibility rules. Learn more.

@qeude
qeude merged commit c84dc2d into main Oct 24, 2026
4 checks passed
@qeude
qeude deleted the fix/install-bundle-name branch October 24, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant