Repository navigation
perf(site): smooth landing hero scroll animation - #144
Merged
Merged
Conversation
- Paint the shrinking bezel outside the video frame to avoid layout reflow - Batch scroll updates to one animation frame
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, self-contained landing-page optimization that scopes bezel painting to the hero and coalesces existing scroll/resize rendering without introducing new capabilities or broader runtime workflows. Its impact is limited to the existing hero animation and presentation. You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
git diff main...HEAD --checkNote
Smooth landing hero scroll animation with bezel repaint and frame-synced growth
mountHeroGrowin hero-grow.js to coalesce scroll/resize updates into one animation frame, share a single geometry measurement per growth pass, and subtract 16px from the resting width for the external bezelmountHeroGrowresting-width calculation now depends on the 16px bezel offset in hero-grow.js; changes to bezel CSS variables in direction.css affect both the pseudo-element size and the growth scaleMacroscope summarized 04203f3.