Skip to content

perf(site): smooth landing hero scroll animation - #144

Merged
qeude merged 3 commits into
mainfrom
t3/smooth-landing-scroll-zoom
Oct 19, 2026
Merged

qeude merged 3 commits into
mainfrom
t3/smooth-landing-scroll-zoom

Conversation

@qeude

@qeude qeude commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Keep the hero video frame size stable while the bezel shrinks during scrolling.
  • Coalesce scroll and resize updates to one animation frame and reuse the layout measurement.

Testing

  • git diff main...HEAD --check
  • Not run: build or browser verification.

View guided diff Turn on auto-fix

Note

Smooth landing hero scroll animation with bezel repaint and frame-synced growth

  • Moves the hero media bezel's painted background, gradient, and highlights to a positioned pseudo-element that extends outside the recording frame, sized by the existing bezel CSS variables in direction.css
  • Reworks mountHeroGrow in hero-grow.js to coalesce scroll/resize updates into one animation frame, share a single geometry measurement per growth pass, and subtract 16px from the resting width for the external bezel
  • Adds a reduced-motion override that restores 8px padding to the media bezel
  • Risk: mountHeroGrow resting-width calculation now depends on the 16px bezel offset in hero-grow.js; changes to bezel CSS variables in direction.css affect both the pseudo-element size and the growth scale

Macroscope summarized 04203f3.

- Paint the shrinking bezel outside the video frame to avoid layout reflow
- Batch scroll updates to one animation frame

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread site/hero-grow.js Resolved
@macroscopeapp

macroscopeapp Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Approvability

Verdict: Approved at 04203f3

Macroscope's review found this PR approvable — This is a small, self-contained landing-page optimization that scopes bezel painting to the hero and coalesces existing scroll/resize rendering without introducing new capabilities or broader runtime workflows. Its impact is limited to the existing hero animation and presentation.

You can add or adjust custom eligibility rules. Learn more.

@qeude
qeude merged commit e0e68a4 into main Oct 19, 2026
6 checks passed
@qeude
qeude deleted the t3/smooth-landing-scroll-zoom branch October 19, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant