Actual better alert box#510
Merged
Merged
Conversation
geoffrey-wu
force-pushed
the
feat/improved-alert-box
branch
from
d38be0b to
527b52a
Compare
geoffrey-wu
force-pushed
the
feat/improved-alert-box
branch
from
527b52a to
39f8ca0
Compare
Member
|
sorry, rebased the alert box doesn't seem very alert-y, i think you should probably just use a bootstrap modal for this 
|
Contributor
Author
|
ok, do you want me to close this pr and make a new one with a bootstrap alert box |
…es/qbreader into feat/improved-alert-box # Conflicts: # server/moderation/ip-filter.js
Contributor
Author
|
Ok I changed it to a bootstrap modal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds client/play/mp/alert.js
Replaces all
window.showAlertcalls with custom alert box display functionAdds html element for custom alert box
also i commented out sections that search the ipbans collection so that i could run locally, you can remove those during merge