Repository navigation
Focus a leftover scan test, and tighten the rules for PR summaries, hand-offs, and quick reviews - #840
Merged
Conversation
… that only it reached A full-Pauli count above the distance raises an error, and a gate that breaks a set of a prepared basis family leaves counts exact. Other tests already count with tiny chunks, forced completion tables, and deformed counters against enumeration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…nts, and quick reviews A PR summary stands alone and gives numbers only when review needs them. A change goes to the maintainer only once all of it is committed, and a protected patch comes with what review has seen of it. Documentation points to details rather than counting them. A quick review's reviewer runs a check only to confirm or rule out a specific problem. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#836 to #839 made the coverage check run qLDPC's compiled functions as plain Python, so tests no longer need hand-written plain-Python variants. One leftover remains:
scan_test::test_counts_with_tiny_chunks_and_forced_tableswas a broad scenario that existed to run the scan's compiled kernels as plain Python for coverage. Only two of its inputs still reach lines ofscan.pythat no other test in its file reaches reliably.Working on that series also showed gaps in the rules for agents. PR summaries referred to other PRs and carried stale numbers. A change was handed off with an uncommitted protected patch, and another patch went for approval without saying that parts of it were unreviewed. A README counted rules defined elsewhere, and the count went stale. A quick review's single reviewer ran a long series of its own experiments on a small change.
Changes
scan_test.py: the broad test becomes two focused tests. One checks that a full-Pauli count above the distance raises an error. The other checks that a counter deformed by a gate that breaks a set of its basis family still counts exactly, against enumeration. Other tests in the file already count with tiny chunks, forced completion tables and deformed counters.AGENTS.md: a change goes to the maintainer to push only once all of its repository changes, including new files, are committed. A protected patch comes with a statement of whether review has seen it as it stands.Testing
scan.pyis still fully covered by its own test file, and the deformed-counter test fails if the scan ignores a set that a gate breaks.