Skip to content

Remove stale opcheck xsuccess entries (jagged/sparse/quantize)#5860

Open
q10 wants to merge 1 commit into
pytorch:mainfrom
q10:export-D107927030
Open

Remove stale opcheck xsuccess entries (jagged/sparse/quantize)#5860
q10 wants to merge 1 commit into
pytorch:mainfrom
q10:export-D107927030

Conversation

@q10

@q10 q10 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary:
generate_opcheck_tests records a "xsuccess" status when a previously-failing opcheck
variant now passes -- i.e. the entry is stale and should be removed. Removing these
de-clutters the failures dicts and drops the problematic-test count with zero
behavioral risk (the tests already pass). 12 stale xsuccess entries removed:

  • jagged: fbgemm::jagged_index_select (KeyedJaggedIndexSelectTest aot_dispatch_dynamic
    • faketensor for test_keyed_jagged_index_select_dim1) -> {}
  • sparse: fbgemm::generic_histogram_binning_calibration_by_feature (4),
    fbgemm::group_index_select_dim0 (2), fbgemm::segment_sum_csr (2) -> {}
  • quantize: fbgemm::FloatToFP8RowwiseQuantized (2) -> {}

Emptied keys are left as {} per the existing convention for healthy ops. Legitimate
xfail entries (data-dependent / dynamic-output-shape variants) are untouched.

Part of the fbgemm_dev test-health remediation for T191384137.

Reviewed By: henrylhtsang

Differential Revision: D107927030

Summary:
generate_opcheck_tests records a "xsuccess" status when a previously-failing opcheck
variant now passes -- i.e. the entry is stale and should be removed. Removing these
de-clutters the failures dicts and drops the problematic-test count with zero
behavioral risk (the tests already pass). 12 stale xsuccess entries removed:

- jagged: fbgemm::jagged_index_select (KeyedJaggedIndexSelectTest aot_dispatch_dynamic
  + faketensor for test_keyed_jagged_index_select_dim1) -> {}
- sparse: fbgemm::generic_histogram_binning_calibration_by_feature (4),
  fbgemm::group_index_select_dim0 (2), fbgemm::segment_sum_csr (2) -> {}
- quantize: fbgemm::FloatToFP8RowwiseQuantized (2) -> {}

Emptied keys are left as {} per the existing convention for healthy ops. Legitimate
xfail entries (data-dependent / dynamic-output-shape variants) are untouched.

Part of the fbgemm_dev test-health remediation for T191384137.

Reviewed By: henrylhtsang

Differential Revision: D107927030
@meta-cla meta-cla Bot added the cla signed label Jun 9, 2026
@meta-codesync

meta-codesync Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@q10 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107927030.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant