Remove stale opcheck xsuccess entries (jagged/sparse/quantize)#5860
Open
q10 wants to merge 1 commit into
Open
Conversation
Summary:
generate_opcheck_tests records a "xsuccess" status when a previously-failing opcheck
variant now passes -- i.e. the entry is stale and should be removed. Removing these
de-clutters the failures dicts and drops the problematic-test count with zero
behavioral risk (the tests already pass). 12 stale xsuccess entries removed:
- jagged: fbgemm::jagged_index_select (KeyedJaggedIndexSelectTest aot_dispatch_dynamic
+ faketensor for test_keyed_jagged_index_select_dim1) -> {}
- sparse: fbgemm::generic_histogram_binning_calibration_by_feature (4),
fbgemm::group_index_select_dim0 (2), fbgemm::segment_sum_csr (2) -> {}
- quantize: fbgemm::FloatToFP8RowwiseQuantized (2) -> {}
Emptied keys are left as {} per the existing convention for healthy ops. Legitimate
xfail entries (data-dependent / dynamic-output-shape variants) are untouched.
Part of the fbgemm_dev test-health remediation for T191384137.
Reviewed By: henrylhtsang
Differential Revision: D107927030
Contributor
|
@q10 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107927030. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
generate_opcheck_tests records a "xsuccess" status when a previously-failing opcheck
variant now passes -- i.e. the entry is stale and should be removed. Removing these
de-clutters the failures dicts and drops the problematic-test count with zero
behavioral risk (the tests already pass). 12 stale xsuccess entries removed:
fbgemm::group_index_select_dim0 (2), fbgemm::segment_sum_csr (2) -> {}
Emptied keys are left as {} per the existing convention for healthy ops. Legitimate
xfail entries (data-dependent / dynamic-output-shape variants) are untouched.
Part of the fbgemm_dev test-health remediation for T191384137.
Reviewed By: henrylhtsang
Differential Revision: D107927030