Restore pyre-fixme comments removed by D106570032 typing migration#5829
Open
q10 wants to merge 1 commit into
Open
Restore pyre-fixme comments removed by D106570032 typing migration#5829q10 wants to merge 1 commit into
q10 wants to merge 1 commit into
Conversation
Summary: D106570032 migrated `fbgemm_gpu/test/` to Python 3.10+ typing (Optional/Dict/List → `| None`, `dict`, `list`). While doing so, several `pyre-fixme[6]` comments were removed in `permute_indices_test.py` and `pack_segments_test.py`, but the underlying type errors were not actually fixed by the migration. This caused the `permute_indices-library-type-checking` and `pack_segments-library-type-checking` tests to fail. This change restores the `pyre-fixme[6]` suppressions, updated to use the new pipe-union syntax to stay consistent with the rest of the migration. No production behavior is changed — only test-file type suppressions. Linked task: T273406771. [Session trajectory link](https://www.internalfb.com/intern/devai/devmate/inspector/?id=7dfd7c17-c5ce-4697-bcad-d6b45ed32aad) Reviewed By: cthi Differential Revision: D107411329
Contributor
|
@q10 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107411329. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
D106570032 migrated
fbgemm_gpu/test/to Python 3.10+ typing (Optional/Dict/List →| None,dict,list). While doing so, severalpyre-fixme[6]comments were removed inpermute_indices_test.pyandpack_segments_test.py, but the underlying type errors were not actually fixed by the migration. This caused thepermute_indices-library-type-checkingandpack_segments-library-type-checkingtests to fail.This change restores the
pyre-fixme[6]suppressions, updated to use the new pipe-union syntax to stay consistent with the rest of the migration. No production behavior is changed — only test-file type suppressions.Linked task: T273406771.
Session trajectory link
Reviewed By: cthi
Differential Revision: D107411329