Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Documentation build overview
9 files changed ·
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcc5ca7a68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| depending on the backends in use. If these settings were already enabled before | ||
| identifier-key tracking, configure the Django backfill's | ||
| ``SOCIAL_AUTH_OLD_ID_KEYS`` with ``sub`` for OAuth2, OpenID Connect, and One Tap, | ||
| or ``id`` for OAuth1. The historical default backfill otherwise uses ``email``. |
There was a problem hiding this comment.
For OpenID Connect and One Tap, the two settings shown above are not the applicable flags because settings are scoped by backend name; historical configurations use SOCIAL_AUTH_GOOGLE_OPENIDCONNECT_USE_UNIQUE_USER_ID and SOCIAL_AUTH_GOOGLE_ONETAP_USE_UNIQUE_USER_ID. Referring to “these settings” while including those backends can lead an operator to conclude that the OAuth2 flag affected them and incorrectly backfill email-based rows as sub, after which indexed lookup will no longer find those associations. List each backend-specific legacy setting or restrict this instruction to the two displayed backends.
Useful? React with 👍 / 👎.
…anges Explain staged ID_KEY changes, historical Django backfill overrides, and evidence requirements so upgrades preserve account bindings without broad JSON searches. Document audited compatibility exceptions and recovery. Fixes python-social-auth/social-app-django#1143 Fixes python-social-auth/social-core#1954 Refs python-social-auth/social-app-django#1120 Refs python-social-auth/social-core#2040
1 participant
…anges
Explain staged ID_KEY changes, historical Django backfill overrides, and evidence requirements so upgrades preserve account bindings without broad JSON searches. Document audited compatibility exceptions and recovery.
Fixes python-social-auth/social-app-django#1143
Fixes python-social-auth/social-core#1954
Refs python-social-auth/social-app-django#1120
Refs python-social-auth/social-core#2040
Refs python-social-auth/social-core#2080