Skip to content

fix(oidc): expire stored login nonces - #2066

Merged
nijel merged 1 commit into
masterfrom
nonce
Oct 6, 2026
Merged

nijel merged 1 commit into
masterfrom
nonce

Conversation

@nijel

@nijel nijel commented Oct 6, 2026

Copy link
Copy Markdown
Member

Bound unfinished login attempts and reject expired nonces to prevent indefinite retention. Stop storing LinkedIn nonces that are never validated and provide shared association expiry checks for storage integrations.

Fixes python-social-auth/social-app-django#918

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T12:47:25.482977Z 7d3a2b3 New commits
🔒 Security Review ✅ Completed 2026-10-06T12:28:29.661893Z eb99ee8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@nijel nijel self-assigned this Oct 6, 2026
@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.30%. Comparing base (32b342f) to head (7d3a2b3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2066      +/-   ##
==========================================
+ Coverage   96.29%   96.30%   +0.01%     
==========================================
  Files         369      370       +1     
  Lines       20659    20753      +94     
  Branches     1197     1207      +10     
==========================================
+ Hits        19893    19987      +94     
  Misses        565      565              
  Partials      201      201              
Flag Coverage Δ
unittests 96.30% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb99ee8d8e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread social_core/backends/open_id_connect.py
Bound unfinished login attempts and reject expired nonces to prevent
indefinite retention. Stop storing LinkedIn nonces that are never validated
and provide shared association expiry checks for storage integrations.

Fixes python-social-auth/social-app-django#918
Comment thread social_core/tests/backends/open_id_connect_nonce.py Dismissed
Comment thread social_core/tests/backends/open_id_connect_nonce.py Dismissed
Comment thread social_core/tests/backends/open_id_connect_nonce.py Dismissed
Comment thread social_core/tests/backends/open_id_connect_nonce.py Dismissed
Comment thread social_core/tests/backends/open_id_connect_nonce.py Dismissed
Comment thread social_core/tests/backends/open_id_connect_nonce.py Dismissed
Comment thread social_core/tests/backends/open_id_connect_nonce.py Dismissed
Comment thread social_core/tests/backends/open_id_connect_nonce.py Dismissed
Comment thread social_core/tests/backends/open_id_connect_nonce.py Dismissed
Comment thread social_core/tests/backends/open_id_connect_nonce.py Dismissed
@nijel
nijel enabled auto-merge (rebase) October 6, 2026 12:48
@nijel
nijel merged commit 8156c00 into master Oct 6, 2026
37 checks passed
@nijel
nijel deleted the nonce branch October 6, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Association model receives new record every time when existing user logs in

1 participant