Extend parent injector multibindings in child injectors - #324
Open
DYNOSuprovo wants to merge 1 commit into
Open
DYNOSuprovo wants to merge 1 commit into
DYNOSuprovo wants to merge 1 commit into
Conversation
Allow child injectors to inherit and extend multibindings registered on their parent injectors for both sequence and mapping multibinds. Fixes python-injector#297 Signed-off-by: DYNOSuprovo <DYNOSuprovo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #297.
Previously, when a child injector configured multibindings on an interface (such as
List[T]orDict[K, V]), a newMultiBinderwas instantiated without reference to the parent injector's multibinder. Consequently,child_injector.get()only retrieved the multibindings defined on the child, completely shadowing the parent's multibindings.This change:
BinderandinterfaceonMultiBinder.MultiBinder.get_scoped_providers(), checks if the owner binder has a parent binder with a registeredMultiBinderfor the same interface, yielding scoped providers from the parent first before yielding child providers.Tests
Added test cases in
injector_test.py:test_multibinds_are_extended_by_child_injectorstest_multibind_dict_is_extended_by_child_injectorstest_multibind_multi_level_hierarchy_extended_by_child_injectorstest_multibind_skipped_level_child_injector