-
Notifications
You must be signed in to change notification settings - Fork 343
lazer/iota: Mainnet deploy #3921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| Move.testnet.toml | ||
| Move.mainnet.toml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| # @generated by Move, please check-in and do not edit manually. | ||
|
|
||
| [move] | ||
| version = 3 | ||
| manifest_digest = "B4D3527E305AD310F2FB380F9ADEA958648C2D763EB756798C848A99F71677D5" | ||
| deps_digest = "F9B494B64F0615AED0E98FC12A85B85ECD2BC5185C22D30E7F67786BB52E507C" | ||
| dependencies = [ | ||
| { id = "Iota", name = "Iota" }, | ||
| { id = "IotaSystem", name = "IotaSystem" }, | ||
| { id = "MoveStdlib", name = "MoveStdlib" }, | ||
| { id = "Stardust", name = "Stardust" }, | ||
| ] | ||
|
|
||
| [[move.package]] | ||
| id = "Iota" | ||
| source = { git = "https://github.com/iotaledger/iota.git", rev = "efc8e49575112ad01a8d8a3b7973f86cc1c716a4", subdir = "crates/iota-framework/packages/iota-framework" } | ||
|
|
||
| dependencies = [ | ||
| { id = "MoveStdlib", name = "MoveStdlib" }, | ||
| ] | ||
|
|
||
| [[move.package]] | ||
| id = "IotaSystem" | ||
| source = { git = "https://github.com/iotaledger/iota.git", rev = "efc8e49575112ad01a8d8a3b7973f86cc1c716a4", subdir = "crates/iota-framework/packages/iota-system" } | ||
|
|
||
| dependencies = [ | ||
| { id = "Iota", name = "Iota" }, | ||
| { id = "MoveStdlib", name = "MoveStdlib" }, | ||
| ] | ||
|
|
||
| [[move.package]] | ||
| id = "MoveStdlib" | ||
| source = { git = "https://github.com/iotaledger/iota.git", rev = "efc8e49575112ad01a8d8a3b7973f86cc1c716a4", subdir = "crates/iota-framework/packages/move-stdlib" } | ||
|
|
||
| [[move.package]] | ||
| id = "Stardust" | ||
| source = { git = "https://github.com/iotaledger/iota.git", rev = "efc8e49575112ad01a8d8a3b7973f86cc1c716a4", subdir = "crates/iota-framework/packages/stardust" } | ||
|
|
||
| dependencies = [ | ||
| { id = "Iota", name = "Iota" }, | ||
| { id = "MoveStdlib", name = "MoveStdlib" }, | ||
| ] | ||
|
|
||
| [env] | ||
|
|
||
| [env.mainnet] | ||
| chain-id = "6364aad5" | ||
| original-published-id = "0x675bb3e3ca140ab1b0eac46ab4bb8b73bef365f544b77764a46d79267998ed48" | ||
| latest-published-id = "0x675bb3e3ca140ab1b0eac46ab4bb8b73bef365f544b77764a46d79267998ed48" | ||
| published-version = "1" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| [package] | ||
| name = "wormhole" | ||
| version = "0.2.0" | ||
| published-at = "0x675bb3e3ca140ab1b0eac46ab4bb8b73bef365f544b77764a46d79267998ed48" | ||
|
|
||
| [addresses] | ||
| wormhole = "0x0" | ||
| wormhole = "0x675bb3e3ca140ab1b0eac46ab4bb8b73bef365f544b77764a46d79267998ed48" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Second iota_mainnet wormhole entry does not collide with existing one
The PR adds a second
iota_mainnetIotaWormholeContractentry (contract_manager/src/store/contracts/IotaWormholeContracts.json:17-21) alongside the existing one. The store keys contracts bygetId()which combines chain and stateId (contract_manager/src/core/contracts/iota.ts:411-413), so the two entries have distinct IDs and won't trigger theMultiple contracts with iderror incontract_manager/src/node/utils/store.ts:246-251. This mirrors the pre-existing pattern whereiota_testnetalready has two entries. No collision, but reviewers should confirm that consumers looking up a wormhole contract by chain (rather than by full id) handle multipleiota_mainnetentries as intended.Was this helpful? React with 👍 or 👎 to provide feedback.