Skip to content

make compatible with pyranges v1 module renamed to pyranges1#13

Merged
marco-mariotti merged 2 commits into
masterfrom
pyrangesv1_migration
Jan 28, 2026
Merged

make compatible with pyranges v1 module renamed to pyranges1#13
marco-mariotti merged 2 commits into
masterfrom
pyrangesv1_migration

Conversation

@marco-mariotti

Copy link
Copy Markdown
Member

After this fix, pyranges tests pass with:
-pyranges v0 0.1.5
-pyranges v1 1.1.9
-pyranges v1 preview after renaming module = https://github.com/d-laub/pyranges_1.x/tree/pyranges1-migration

BUT pyrle built-in tests don't pass. Not even with old versions, though. I think we just neglected them for a long time

@marco-mariotti

Copy link
Copy Markdown
Member Author

@endrebak I will not merge this myself.
When you do, upload to pip

@endrebak

Copy link
Copy Markdown
Collaborator

It seems to break. Why? I think the incorrect overlap edge cases in ruranges are much more important to fix than this.

If it is just pyrle that does not work I think we can remove those tests.

@marco-mariotti

Copy link
Copy Markdown
Member Author

Hi @endrebak , the tests were broken before this PR. I barely changed anything other than import statements and some logging. Now: I push this merge and upload to pip to have tests working in renamed pyranges1. I leave the related issue open waiting for pyrle own tests to be fixed (or solve the problem in other ways).
Hopefully you're ok with this, otherwise we can always roll back, bump and reupload to pip

@marco-mariotti marco-mariotti merged commit 1760d33 into master Jan 28, 2026
1 of 9 checks passed
@endrebak

Copy link
Copy Markdown
Collaborator

♥️👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants