make compatible with pyranges v1 module renamed to pyranges1#13
Merged
Conversation
Member
Author
|
@endrebak I will not merge this myself. |
Collaborator
|
It seems to break. Why? I think the incorrect overlap edge cases in ruranges are much more important to fix than this. If it is just pyrle that does not work I think we can remove those tests. |
Member
Author
|
Hi @endrebak , the tests were broken before this PR. I barely changed anything other than import statements and some logging. Now: I push this merge and upload to pip to have tests working in renamed pyranges1. I leave the related issue open waiting for pyrle own tests to be fixed (or solve the problem in other ways). |
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this fix, pyranges tests pass with:
-pyranges v0 0.1.5
-pyranges v1 1.1.9
-pyranges v1 preview after renaming module = https://github.com/d-laub/pyranges_1.x/tree/pyranges1-migration
BUT pyrle built-in tests don't pass. Not even with old versions, though. I think we just neglected them for a long time