Add explicit setuptools dependency#390
Open
tomwardio wants to merge 1 commit into
Open
Conversation
Author
|
Without explicitly depending on setuptools, tests fail with the following: |
For Python >=3.12, setuptools is not longer included by default. Even for older distros, setuptools may not necessarily be included by default (e.g. building locally doesn't necessarily include setuptools).
7fed549 to
8ccde3a
Compare
tomwardio
added a commit
to google-deepmind/alphagenome
that referenced
this pull request
Nov 18, 2024
Currently pyranges implicitly relies on setuptools. pyranges/pyranges0#390 will rectify this, but in the meantime explicitly add setuptools to our project. PiperOrigin-RevId: 696463550 Change-Id: I7d6450de0ebc35db9d585bf0df440a644ec4d657
Contributor
|
I think importlib_resources is the preferred approach. |
Author
Yes that would be even better! I did the minimum to get this package to work with 3.12. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Python >=3.12,
setuptoolsis not longer included by default. Even for older distros, setuptools may not necessarily be included by default (e.g. building locally doesn't necessarily include setuptools).