fix: regenerate FONcpp reference CSVs missed by #404#405
Open
Lgz-tud wants to merge 1 commit into
Open
Conversation
PR pymanga#404 changed Jabowa.self.grow to cm/step and regenerated 11 Jabowa benchmark references, but missed the FONcpp/FONcpp_CI ones introduced by PR pymanga#400. master CI has been failing on these two since the merges (see GitHub Actions run 27071948305). Why the gap: PR pymanga#404 was branched off master before PR pymanga#400 merged, so its own CI never included the FONcpp benchmarks (they were registered in BenchmarkList.xml only after PR pymanga#400 landed). The mismatch only surfaced once both PRs were merged on master. Only the `growth` column changes (cm/yr -> cm/step); all other fields (r_stem, height, x, y, ag_factor, bg_factor) are bit-for-bit identical. Verified locally with `pytest Benchmarks/test_Benchmarks_CI.py`: 56 subtests passed.
There was a problem hiding this comment.
Pull request overview
Regenerates the Jabowa + FONcpp/FONcpp_CI benchmark reference CSVs so the growth column matches the post-#404 convention (cm/step), unblocking CI failures on the C++-backend FON benchmarks.
Changes:
- Updated
growthvalues in FONcpp and FONcpp_CI reference population CSVs at the affected timestamps. - Aligns FONcpp/FONcpp_CI reference outputs with the already-correct per-step convention used by the simulation output on
master.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Benchmarks/ModuleBenchmarks/PlantModules/Jabowa/Belowground/FON/ReferenceFiles/FONcpp/Population_t_0002000000.0.csv | Regenerated reference values (notably growth) to match cm/step. |
| Benchmarks/ModuleBenchmarks/PlantModules/Jabowa/Belowground/FON/ReferenceFiles/FONcpp/Population_t_0500000000.0.csv | Regenerated reference values (notably growth) to match cm/step. |
| Benchmarks/ModuleBenchmarks/PlantModules/Jabowa/Belowground/FON/ReferenceFiles/FONcpp_CI/Population_t_0002000000.0.csv | Regenerated CI reference values (notably growth) to match cm/step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Regenerate the three reference CSVs for the Jabowa + FONcpp benchmarks:
Benchmarks/ModuleBenchmarks/PlantModules/Jabowa/Belowground/FON/ReferenceFiles/FONcpp_CI/Population_t_0002000000.0.csvBenchmarks/ModuleBenchmarks/PlantModules/Jabowa/Belowground/FON/ReferenceFiles/FONcpp/Population_t_0002000000.0.csvBenchmarks/ModuleBenchmarks/PlantModules/Jabowa/Belowground/FON/ReferenceFiles/FONcpp/Population_t_0500000000.0.csvWhy
#404 changed
Jabowa.self.growtocm/stepand regenerated reference CSVs for 11 Jabowa benchmarks, but missed the FONcpp / FONcpp_CI references introduced by #400.masterCI has been failing on these two benchmarks since #404 was merged — only thegrowthcolumn mismatched (cm/yr in the reference, cm/step in the simulation).#404 was branched off
masterbefore #400 merged, so its head'sBenchmarkList.xmldid not yet registerFONcpp_CI. PR-level CI (pull_requesttrigger) therefore never ran the FONcpp benchmarks, and the mismatch only surfaced once both PRs landed onmaster.