Introducing Saltmarsh Model#380
Open
jvollhueter wants to merge 41 commits into
Open
Conversation
jvollhueter
added
bug
mcwimm
reviewed
Apr 22, 2025
mcwimm
reviewed
Apr 22, 2025
mcwimm
left a comment
mcwimm
left a comment
Collaborator
There was a problem hiding this comment.
Please rebase this PR on to the current master (don't merge the master into the branch).
jvollhueter
force-pushed
the
SaltmarshModel
branch
from
199d6d1 to
78d4bb3
Compare
mcwimm
reviewed
Apr 23, 2025
mcwimm
left a comment
mcwimm
left a comment
Collaborator
There was a problem hiding this comment.
So far, I only checked the documentation. The rest is coming later.
jvollhueter
force-pushed
the
SaltmarshModel
branch
from
78d4bb3 to
0f458ff
Compare
Closed
jvollhueter
force-pushed
the
SaltmarshModel
branch
from
0f458ff to
f8e1c0e
Compare
mcwimm
reviewed
Apr 23, 2025
mcwimm
left a comment
mcwimm
left a comment
Collaborator
There was a problem hiding this comment.
Please make benchmarks consistent & adjust do the documentation similar to existing module descriptions, e.g., https://pymanga.github.io/pyMANGA/pyMANGA/ResourceLib/BelowGround/Individual/FixedSalinity.html
jvollhueter
force-pushed
the
SaltmarshModel
branch
2 times, most recently
from
a4421e3 to
1dbbd38
Compare
jvollhueter
force-pushed
the
SaltmarshModel
branch
from
1dbbd38 to
31a58a5
Compare
jvollhueter
force-pushed
the
SaltmarshModel
branch
from
0e0e887 to
9e36751
Compare
added 29 commits
June 9, 2026 23:00
In case of negative growth the growth factor is excluded from calculation of volume changes
jvollhueter
force-pushed
the
SaltmarshModel
branch
from
bab0c0d to
6c20f7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another clean Branch for the introduction of the saltmarsh model.