setup.py: remove unnecessary setuptools (runtime) dependency#1379
Merged
Conversation
setuptools should only be necessary for building package, but not for using it It was introduced ~9 years ago in this commit pyinfra-dev@be47be5 , likely for `pkg_resources`, but pyinfra migrated off it since due to deprecation
Contributor
Author
|
Hmm some random test failed, I guess it's just flaky? Doesn't seem like I can retry CI for some reason. |
Fizzadar
approved these changes
Jun 23, 2025
Fizzadar
left a comment
Fizzadar
left a comment
Member
There was a problem hiding this comment.
Great spot, thanks for fixing this @karlicoss!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setuptools should only be necessary for building package, but not for using it
It was introduced ~9 years ago in this commit be47be5 , likely for
pkg_resources, but pyinfra migrated off it since due to deprecation3.xat this time)scripts/dev-test.sh)scripts/dev-lint.sh)