[BUG] pyrato intersection_time_lundeby#170
Merged
Merged
Conversation
f-brinkmann
force-pushed
the
fix/intersection_time_lundeby
branch
from
ffe373e to
4975a5f
Compare
f-brinkmann
force-pushed
the
fix/intersection_time_lundeby
branch
from
4975a5f to
c4afe22
Compare
f-brinkmann
requested review from
a team,
ahms5,
artur-pa,
hoyer-a,
mberz and
sbch22
hoyer-a
reviewed
May 4, 2026
hoyer-a
left a comment
hoyer-a
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing and extending the tests.
I have one suggestion
h-chmeruk
requested changes
May 4, 2026
h-chmeruk
left a comment
h-chmeruk
left a comment
Contributor
There was a problem hiding this comment.
Thanks for catching this and implementing the fix! It looks good to me :)
I noticed just one typo in the function name, otherwise approved
Co-authored-by: Hanna Chmeruk <119290248+h-chmeruk@users.noreply.github.com>
h-chmeruk
approved these changes
May 4, 2026
ahms5
approved these changes
May 5, 2026
f-brinkmann
added a commit
that referenced
this pull request
May 5, 2026
`pyrato.edc.intersection_time_lundby` failed for multidimensional Signals ### Changes proposed in this pull request: - reshape internal data to make sure the cshape of the input data is maintained - update and improve testing --------- Co-authored-by: Hanna Chmeruk <119290248+h-chmeruk@users.noreply.github.com>
h-chmeruk
added a commit
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyrato.edc.intersection_time_lundbyfailed for multidimensional SignalsChanges proposed in this pull request: