Fix empty search page when search_as_you_type and dirhtml is used#2448
Open
consideRatio wants to merge 1 commit into
Open
Fix empty search page when search_as_you_type and dirhtml is used#2448consideRatio wants to merge 1 commit into
consideRatio wants to merge 1 commit into
Conversation
The setupSearchAsYouType guard checked for a pathname ending in /search.html, which the dirhtml builder's search/ URL never matches, so the inline search removed the search page's #search-results container (searchtools.js's render target) and recreated it empty inside the search dialog, leaving the page blank. The Escape-key handler reached resetSearchAsYouTypeResults through a second path with the same effect, even under the html builder. Force the search_as_you_type flag off on the dedicated search page from the html-page-context hook instead, mirroring the pagename == 'search' guard in layout.html. That disables every inline-search entry point there through the existing flag guards, for every builder, and the pathname check becomes dead code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setupSearchAsYouType guard checked for a pathname ending in
/search.html, which the dirhtml builder's search/ URL never matches, so
the inline search removed the search page's #search-results container
(searchtools.js's render target) and recreated it empty inside the
search dialog, leaving the page blank. The Escape-key handler reached
resetSearchAsYouTypeResults through a second path with the same effect,
even under the html builder.
Force the search_as_you_type flag off on the dedicated search page from
the html-page-context hook instead, mirroring the pagename == 'search'
guard in layout.html. That disables every inline-search entry point
there through the existing flag guards, for every builder, and the
pathname check becomes dead code.