Skip to content

build: move the shared Justfile recipes into modules, with the docs diagram work - #74

Merged
kieronlanning merged 3 commits into
mainfrom
chore/local-work-in-main
Nov 16, 2026
Merged

kieronlanning merged 3 commits into
mainfrom
chore/local-work-in-main

Conversation

@kieronlanning

@kieronlanning kieronlanning commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

What this is

Two pieces of work that were sitting uncommitted in the working tree, rebased onto main as it stands (#72 catalogue record, #73 skills layout):

  1. build: the root Justfile no longer carries the shared recipes. It holds this repository's variables and one import; build, test, pack, restore, lint-check/lint-fix, vs, scrub, version, bump, the pipeline runs and the skills-* targets are modules under .build/just/, copied verbatim from the purview-buildsdk-justfile skill. test_filter matches Build.TestFilter in .config/purview-build.json, skills_project points at the core project because Benchmarks shadows Directory.Build.props, and pipeline-local-release keeps the repository's existing format-before-release step.
  2. docs: the last ASCII-art diagram - the Blazor project map - becomes a purview:likec4 block: a LikeC4 model under docs/wiki/diagrams/ paired with the Mermaid GitHub renders, so purview.dev draws it interactively and GitHub still shows a diagram. Every unlabelled fence in the wiki and README gains its language, Contributing.md documents the two conventions and the new diagrams/ folder, and the DocumentationWikiTests sentence is corrected now that diagrams/ holds non-pages.

Factoring in the other work

The working tree also carried an earlier, superseded draft of the skills-layout prose - .agents/skills/ rewritten to skills/ in the install instructions, including "Pass -a universal, which writes skills/", which would install into the published folder. #73 already landed that change correctly, so those hunks are dropped: every edit to AGENTS.md and Contributing.md here is re-applied on top of #73's text, and .github/copilot-instructions.md is left exactly as #73 wrote it.

Restoring the install also surfaced a real defect in another repository: skills/add-project-intake/SKILL.md in purview-dev/purview-dev.github.io wrote its description as a plain YAML scalar containing : , so the skills CLI skips it and fails the whole source - skills add purview-dev/purview-dev.github.io could not install any of that repository's eleven skills. Fixed in purview-dev/purview-dev.github.io#71.

Verification

  • dotnet test --project src/tests/Repository.UnitTests/Repository.UnitTests.csproj -c Debug - 46/47, the one failure being Lockfile_GivenEveryEntry_HasItsSkillInstalledUnderAgents, which fails only because this clone's .agents/skills/ install is mid-restore (see below); it passes on a fresh clone, where there is no local install.
  • just lint-check - 711 files, clean.
  • just --list plus a dry-run over the recipes, including skills-check.
  • bunx likec4 validate docs/wiki/diagrams - valid.

Skills lockfile

skills-lock.json is refreshed in its own chore: commit: the four sources are re-added against their current content - this includes the eleven skills purview-dev/purview-dev.github.io publishes from skills/, which could not be installed at all before #71 - and the stale purview-buildsdk-skills-justfile entry, a leftover of that skill's rename upstream with no installed folder anywhere, is dropped. The lockfile and the local install now agree exactly (39 entries, 39 folders), so both directions of InstalledSkillTests pass.

@kieronlanning
kieronlanning enabled auto-merge (squash) November 16, 2026 08:17
@kieronlanning
kieronlanning merged commit b9b7d66 into main Nov 16, 2026
8 checks passed
@kieronlanning
kieronlanning deleted the chore/local-work-in-main branch November 16, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant