Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/copilot-instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ root. Read it first and treat it as the source of truth for:
- Project structure and layout
- Build and validation workflow
- Conventions (conventional commits, csharpier, `.slnx`, SDK behaviour)
- Installed source-generator, testing and SDK skills (`.agents/skills/`, committed)
- Installed source-generator, testing and SDK skills (`.agents/skills/`, gitignored; restored with `just skills-install` from the committed `skills-lock.json`)
- Benchmarking and performance documentation rules
- Release process

Expand Down
21 changes: 11 additions & 10 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ benchmarks/
└── Purview.Telemetry.Benchmarks/ # BenchmarkDotNet project (net48/net10.0/net11.0)

.build/ # TS scripts (build-pack.ts, update-version.ts) and just/ modules
.agents/skills/ # Installed + developer skills, committed (see "Installed skills")
.agents/skills/ # Installed skills (gitignored; see "Installed skills")
skills-lock.json # The skills CLI lockfile for .agents/skills/, committed
skills/ # Authored skills shipped by this package (see "Authoring skills")
.config/ # dotnet-tools.json, lefthook.yml
Expand Down Expand Up @@ -272,9 +272,11 @@ table of gates is in [`docs/wiki/contributing/Release-Flow.md`](docs/wiki/contri

Specialist source-generator and SDK guidance — `CodeWriter` emission, incremental pipeline design,
test runners and `CodeQuery`, `Purview.BuildSdk` configuration — is published by the repositories
that own it, and installed here by the skills CLI. The installed skills are **committed**:
`.agents/skills/**` and the CLI's `skills-lock.json` (source, skill path and content hash of every
entry) are both in source, so a clone has them without running anything.
that own it, and installed here by the skills CLI. Only the CLI's `skills-lock.json` (source, skill
path and content hash of every entry) is committed: `.agents/skills/` is a local install, gitignored so
a skill this repository installs but does not publish can never be found through
`skills add purview-dev/telemetry-sourcegenerator`. A fresh clone restores the set with
`just skills-install`.

| Skill | Source | Load before |
| --- | --- | --- |
Expand All @@ -290,15 +292,14 @@ entry) are both in source, so a clone has them without running anything.

This repository's own skills in `skills/` are authored for **consumers** of its packages, not for use while working on this repository. They are never installed into this repository's `.agents/skills/`; `InstalledSkillTests` enforces this.

`.agents/skills/` also holds the **developer skills**: skills written here for people working on the
generator, which are not consumer guidance and are never published. They are committed in place (the
skills CLI neither writes them nor records them in the lockfile), and `InstalledSkillTests` allows a
folder there only when it is declared in that class's `DeveloperSkills` list, which also asserts the
skill cannot drift into `skills/`.
`skills/` also holds the **developer skills**: skills written here for people working on the
generator, which are not consumer guidance. They are authored like any other skill — the skills CLI
neither installs them nor records them in the lockfile — and `InstalledSkillTests` declares them in
`DeveloperSkills`, which asserts each one ships from `skills/` and reaches no lockfile.

| Developer skill | Answers |
| --- | --- |
| `.agents/skills/purview-telemetry-benchmarks/` | running the BenchmarkDotNet suite for .NET 10 / .NET 11 / .NET Framework 4.8, reading a report, refreshing `docs/wiki/reference/Performance.md` and `README.md`, writing the analysis, adding a family |
| `skills/purview-telemetry-benchmarks/` | running the BenchmarkDotNet suite for .NET 10 / .NET 11 / .NET Framework 4.8, reading a report, refreshing `docs/wiki/reference/Performance.md` and `README.md`, writing the analysis, adding a family |

Skills are installed into the universal `.agents/skills/` location **only**. Never install copies
into `.claude/` or any other per-agent folder. Pass `-a universal`, which writes `.agents/skills/`
Expand Down
Loading