Port int64/uint64 to int/uint for 32-bit compatibility#873
Conversation
This commit ports the internal use of fixed-width 64-bit integers (int64, uint64) to machine-sized integers (int, uint) across the entire codebase. This ensures that mgmt is buildable on 32-bit architectures while still respecting external library requirements for 64-bit types. Key changes: - Updated lang/types.Value interface and IntValue struct to use int. - Updated engine.MetaParams.Delay to use uint. - Updated various resource fields (timeouts, ports, etc.) to use uint/int. - Modernized string conversions to use architecture-aware strconv functions. - Ensured explicit casts to int64 for external library calls (e.g., time.Unix). - Updated the test suite to reflect the new integer types. Co-authored-by: purpleidea <135091+purpleidea@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Ported
int64anduint64tointanduintrespectively throughout the codebase to support 32-bit machines. This includes core types, AST, built-in functions, and resource parameters. Library-dependent 64-bit types were preserved with explicit casts where necessary.PR created automatically by Jules for task 7771913843721359248 started by @purpleidea