Repository navigation
fix(present): pace the menu on the acquire again - #28
Merged
Merged
Conversation
Paced on the vblank with one frame queued, every menu frame past the refresh repeated one: a tab change draws frames of 29 to 36 ms at CPU 2091, and the menu hitched where v1.0.0 did not. Only a stream paces on the vblank now; the menu keeps two frames queued, as v1.0.0 did. A stream starts with the vsync event cleared and no drain left from the menu's frames. The stream's pacing, the late take and the markers are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #21 the menu paced on the vblank with one frame queued, like a stream. A tab change draws a few frames of 29 to 36 ms even at CPU 2091 (log 2026-11-19 01:29Z:
cpu p99 ~6-7 ms, max 28.9 / 17.1 / 36.0 ms, 581 and 597 of 600 frames), and with one frame queued each of them repeats a refresh. v1.0.0 kept two frames queued and hid them.Pace::set_streaming, called fromPresenter::set_stream: only a stream paces on the vblank; the menu, the connect screen and a redial pace on the acquire.fila-antiga/sem-esperamarkers are unchanged.presenter: …now says the menu goes by the acquire; the menu'spresent[10s]lines readon the acquire.Tests:
cargo test -p pf-nx-vk --lib pacing(newonly_a_stream_paces_on_the_vblank), fmt and clippy clean.To test on the console: switch tabs in the menu at stock clocks and with the clock raised; then a stream, checking
present[10s]still readson the vblank, taken latewith0 found a frame queuedafter the first window.Lightening the tab change itself is a later change in
pf-console-ui.