Remove all-contributors-cli from repo#315
Open
confused-Techie wants to merge 1 commit into
Open
Conversation
1 task
Member
Author
|
@all-contributors please add @schadomi7 for code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #311 the renovate bot tried to update the
all-contributors-clibut failed since it didn't match the version of NodeJS this project uses.Checking the repository it was last updated in 2023. It terns out the modern recommendation is to use the
all-contributors botto handle these updates, rather than the CLI.So in this PR I remove the CLI dependency, as well as the NPM script used to help update it.
I'll take the time now to ensure that all existing contributors are being granted the proper attribution for their work in the project, then we will just have to ensure to ping the bot on pull requests in the future.